Make config raise specific domain specific error #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telphan
force-pushed
the
new_argument_error
branch
from
8d2c3fe to
3abe19e
Compare
jonathan-duffel
approved these changes
Oct 27, 2022
telphan
force-pushed
the
new_argument_error
branch
from
3abe19e to
c77645f
Compare
|
We need to disable the requirement for: |
jesse-c
reviewed
Oct 27, 2022
| @@ -20,6 +20,10 @@ defmodule Paginator.Config do | |||
| :total_count_limit | |||
| ] | |||
|
|
|||
| defmodule ArgumentError do | |||
There was a problem hiding this comment.
fix: I don't think this is necessary since the Elixir stdlib for Exceptions already has this [1]? @ulissesalmeida: Is that correct?
[1] https://github.com/elixir-lang/elixir/blob/main/lib/elixir/lib/exception.ex#L807
There was a problem hiding this comment.
Ahh yea, we should use def exception indeed 👍🏽
jesse-c
pushed a commit
that referenced
this pull request
Oct 27, 2022
This is to test my idea from #176 (comment) where I've said that I don't think this is necessary since the Elixir stdlib for Exceptions already has this [1]? [1] https://github.com/elixir-lang/elixir/blob/main/lib/elixir/lib/exception.ex#L807
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation for this PR is to be able to target these errors specifically.